Module 3 Exercise 1: Pull requests


(Vanessa) #21

Just gave you feedback :slight_smile:


(Vanessa) #22

@bensoltoff if you want feedback, please tag me, @mozzadrella


(Mike Zamansky) #23

A screenshot of my pullrequest:


(Miren Berasategi) #24

Here’s the screenshot of my pull request:


(Vanessa) #25

Hi @zamansky tag me if you’d like a :raised_hand: :sparkles:


(Mike Zamansky) #26

So I guess I’m supposed to tag @mozzadrella. Here’ goes.


(Paola Corrales) #27

This was challenging! :sweat_smile:


(Rishabh Bansal) #28

Hi @mozzadrella, This is my Module 3.1 exercise submission. :slight_smile:


(JuanMa) #29


(Vitor Rios) #30

no real questions about pull requests, but the tracking branch thing had me a little confused


(Tess Homan) #31


(Vanessa) #32

I prefer to call it “remote tracking branch” in my head to keep it discrete from local. :sparkles:


(Alexander L. Hayes) #33

Posting pull request photo, I used the same repository from the Module 2 repository.


(Vicente Cubells) #34

Module 3 Exercise 1


(Ryan Schuetzler) #35

Thar she blows


(Mark Patterson) #36

Also wondering if @mentions work in a private repositiory.

@mozzadrella Am I right in thinking that a person has to be added as a collaborator to the repo before they can be added as a pull request reviewer?


(Alexander L. Hayes) #37

Not mozzadrella, but you’re correct. You’ll usually get recommendations based on who recently edited the files recently, followed by “Everyone else.”

image


(Danny de Vries) #38


(Vanessa) #39

@markpatterson27 you are correct. You’ll need to add me as a collaborator before you can mention @mozzadrella but then it should autofill.


(Joachim Francois) #40

Added @mozzadrella as a collaborator I’ll updated you in the Reviewers once you’ve accepted the collaboration request.

image