Module 3 Exercise 1: Pull requests

Just gave you feedback :slight_smile:

@bensoltoff if you want feedback, please tag me, @mozzadrella

A screenshot of my pullrequest: 5

1 Like

Here’s the screenshot of my pull request:

Screenshot-2018-3-12%20Add%20my%20questions%20by%20mberasategi%20%C2%B7%20Pull%20Request%20%231%20%C2%B7%20mberasategi%20module3

1 Like

Hi @zamansky tag me if you’d like a :raised_hand: :sparkles:

So I guess I’m supposed to tag @mozzadrella. Here’ goes.

This was challenging! :sweat_smile:

screenshot_4

1 Like

Hi @mozzadrella, This is my Module 3.1 exercise submission. :slight_smile:

08%20PM

2 Likes

40

1 Like

no real questions about pull requests, but the tracking branch thing had me a little confused
image

Exercise%201%20Module%203

1 Like

I prefer to call it “remote tracking branch” in my head to keep it discrete from local. :sparkles:

1 Like

Posting pull request photo, I used the same repository from the Module 2 repository.

pull_request_3_1

1 Like

Module 3 Exercise 1

vcubells%20module%203%20exercise%201

2 Likes

Thar she blows

image

1 Like

2018-04-17%20(2)

Also wondering if @mentions work in a private repositiory.

@mozzadrella Am I right in thinking that a person has to be added as a collaborator to the repo before they can be added as a pull request reviewer?

2 Likes

Not mozzadrella, but you’re correct. You’ll usually get recommendations based on who recently edited the files recently, followed by “Everyone else.”

image

1 Like

59

1 Like

@markpatterson27 you are correct. You’ll need to add me as a collaborator before you can mention @mozzadrella but then it should autofill.

Added @mozzadrella as a collaborator I’ll updated you in the Reviewers once you’ve accepted the collaboration request.

image

1 Like
© 2017 GitHub, Inc.
with by
GitHub Education